Assembly is not strong-named
pedropaulovc opened this issue · 3 comments
Repro steps:
- Download the latest version from NuGet
- Unpack the
.nupkg
file - Run
sn -vf DistributedLock.1.5.0\lib\net45\DistributedLock.dll
Expected:
The sn.exe
tool would output
Microsoft (R) .NET Framework Strong Name Utility Version 4.0.30319.0
Copyright (c) Microsoft Corporation. All rights reserved.
Assembly 'DistributedLock.1.5.0\lib\net45\DistributedLock.dll' is valid
Actual:
The sn.exe
tool outputs
Microsoft (R) .NET Framework Strong Name Utility Version 4.0.30319.0
Copyright (c) Microsoft Corporation. All rights reserved.
DistributedLock.1.5.0\lib\net45\DistributedLock.dll does not represent a strongly named assembly
Observation:
This blocks strong-named .NET assemblies from depending on DistributedLock
. See Why strong-name your assemblies?
@madelson Hi, could you please release version 1.5.1 (or 1.6.0) that is identical to 1.5.0 and is strongly named. So we don't need to wait and migrate to new version only to get strongly named assembly.
@maxkoshevoi This is what @madelson said in #48 :
Hi @pedropaulovc thanks for contributing.
Since adding a strong name to an assembly is a binary breaking change, I won't be able to merge this into the 1.x series.
I am currently working on the 2.0 version (see the 2.0 branch) which is intended to have strong-named assemblies. Would you consider performing this change on the 2.0 branch and filing a PR against that branch?
Thanks!
@maxkoshevoi the alpha02 versions of releases should be fairly stable (tests are passing, no major further breaking API changes planned) and have strong names.