Where is a dApp's icon taken from?
PureSpider opened this issue · 3 comments
Is temple using exclusively favicon.ico to display a dApp's icon in the wallet popups?
Can this be changed so it uses other defined site icons, as well?
Hi
Yes, we are using DApps favicon.ico icons to display them on confirmation popups.
What "other defined site icons" do you offer to use?
Basically any icon that you can somehow define as the site's icon (see https://stackoverflow.com/a/26768184/953010) - or for starters, using the favicon defined in the header instead of forcing a default location
@PureSpider , yes, the QuipuSwap uses appMeta.icon in dapp payload's request and TempleWallet using that icon url for rendering dapp's icon. But if there no icon in appMeta, then it will fallback to dapp url + /favicon.ico
PR, that fixes this issue is #636