madodig/wikijs-customization

enable collapsible menu to safari browser

LeoRP-12 opened this issue · 2 comments

How can I solve this?

I used the available code but the collapsible menu doesn't work in the safari browser, the text for the page is shown in blank

MicrosoftTeams-image

This issue is not only related to Safari, but to mobile devices in general.

Customization code parses the page while its loading and then modifies some parts of it. It's not working as expected on mobile devices because of how the original div elements are laid out, or custom CSS code is not working with mobile device. Or both :/
What you can do is compare how the original page (html) looks like on both desktop and mobile, with how it looks when customization code is enabled and see if there's anything you can do in custom CSS and/or JS to adapt it to your needs.

I've used mobile devices emulation to check how it renders while I was working on it, but it wasn't working when viewed on real mobile devices. That's why I decided to stick with the desktop only and focus on features I wanted, while disabling parts of the code for mobile devices.

I'll leave this issue opened in case I decide to make it work for the mobile devices as well...

It would be great if this issue for Safari (and mobile) could be solved.

Here is the collapsible menu in Edge:
https://www.screencast.com/t/CSludkFD

Here is the collapsible menu in Safari:
https://www.screencast.com/t/1pYhCReusY

I think that we must recognize the possibility that v3 may not be release in 2023 at all. This means that we must continue with v2.5.X for a long time.

This set of customizations you have created brings a few key features that are crucial to using wikijs in production. For me, it is menu collapse/expand. Without functioning menu collapse/expand, I cannot launch this system in production.

I would be happy to make a donation to you if it would help you invest the time required to fix this issue.