madpah/requirements-parser

Support private Repositories

Opened this issue · 3 comments

SirUli commented

As a follow-up to the #63 it would be awesome if you could add support for private repositories (currently they are not (https://github.com/madpah/requirements-parser/blob/master/requirements/parser.py#L72-L76)).

This came out of the detective work for ansible/ansible-builder#319 where I'd love to see these supported.

Thanks in advance!

eqrx commented

I wanted to open a PR for it but I noticed that requirements-parser represents actual requirements as the class Requirement and drops everything else (now gracefully, good job :) ). I am wondering how this could be implemented:

  • Allow Requirement to hold an option or a requirement line. I am unsure how to implement that without breaking the API
  • Extra class for options, so a set of Requirement instances would be returned with a set of Option ... but that would also break the current API.

Any thoughts?

JoelKle commented

+1 for supporting private PIP repositories

Akasurde commented

Any news?