mag37/dockcheck

New update check doesn't honor -y parameter

Closed this issue · 2 comments

Hi! I just noticed this with the new update:

❯ cd ~/github/dockcheck/ && ./dockcheck.sh -y -p
New version available! Local: v0.2.3 - Latest: v0.2.4
Change Notes: Fixes to the Exclude-option to only exclude exact matches. +cleaning
Choose update procedure (or do it manually) - git/curl/[no]:

Which prevents my cron task from running. Maybe you could add another option for automatic updates?

Thank you for a great tool!

mag37 commented

Great find! I didn't think of that breaking the no-interaction flags.

Did a quick fix that should solve it.
If the -y|a flag is passed it will just print the "New version.."-info and then skip the self-update interaction (and thereby the update too).

I dont think having scheduled auto self-updates is a great idea, but if you think the option should be there I'll look into it in the future.

I pulled the latest version and it works great!

You're probably right though - auto updating would't be such a good idea.

Thank you for such a quick response.