Remove adobe data-collection code and modal

Question

Remove adobe data-collection code and modal

Vinai opened this issue a year ago · 6 comments

Vinai commented a year ago

Both the adobe data-collection modal and the code to collect the data should be removed.

Preconditions and environment

Mage-OS 1.0.0 preview

Steps to reproduce

Install the 1.0.0 preview and log into the backend as an admin user.

Expected result

I see the admin dashboard.

Actual result

I see the data-collection agreement modal dialog.

Answer 1 · 2023-10-07T20:02:20.000Z

Are we looking to remove those specific aspects, or the entire AdminAnalytics module? I believe that's the entire purpose of the module. https://github.com/mage-os/mageos-magento2/tree/2.4-develop/app/code/Magento/AdminAnalytics

The package code is magento/module-admin-analytics

Answer 2 · 2023-10-07T21:13:22.000Z

Removing it would be best, however, because of upstream compatibility we maybe could keep it but short-circuit all functionality?

Answer 3 · 2023-10-07T21:14:39.000Z

Or, maybe we remove it after all, since resolving merge conflicts with upstream will probably be rather simple :)

EDIT: more info and discussion in the PR #45 from @pykettk

Answer 4 · 2023-10-09T06:18:32.000Z

Reopening because the tracking URL still needs to be removed.

Answer 5 · 2023-10-09T07:47:22.000Z

The modal is still showing upon the first login.

It is a ui component, so making the block depend on the configuration flag didn't do the trick.
In app/code/Magento/AdminAnalytics/view/adminhtml/layout/adminhtml_dashboard_index.xml:

<uiComponent name="admin_usage_notification" ifconfig="admin/usage/enabled">

may do the trick.

Answer 6 · 2023-10-09T09:43:14.000Z

The modal still displays, because the default config value is evaluated as " 0 ", which is true when used with isSetFlag. Without wrapping space it evaluates correctly to false.