Write a Github Action that runs the the semantic version checker as defined by https://developer.adobe.com/commerce/testing/guide/svc/
Opened this issue · 8 comments
So, the semver checker tool wants to compare whatever changes you have against a known version or tag. I don't see a way to have it auto-determine which version your new change or branch should validate against, so should I just hard-code it to 2.4-develop for now, and we'll just bump it manually as new (or old) versions are added?
From the instructions:
- Navigate the magento-semver folder and run the Semantic Version Checker compare command:
bin/svc compare ../magento2-mainline ../magento2
The first parameter is the mainline code without any changes, and the second parameter is the path to the folder with your changes. The results of the Semantic Version Checker are outputted to the console.
Unrelated question: Check semver on every push, on pull requests, what trigger do we want to use?
On PRs only currently, comparing the diff of the PR against the original HEAD.
See the following potential pull request into the MageOS repo: 2.4-develop...lefte:magento2:feature/issue-5-github-action-semantic-checker
Would this be the right spot to create a PR to?
On PRs only currently, comparing the diff of the PR against the original HEAD.
Hopefully this is what you meant, it compares the new pull request's head branch against the base branch
@lefte this is exactly it! Thank you so so so much!
🚯 Ah, I see it doesn't like pull requests from forked repositories, let me check on which variable to use for that
Alright, I believe the newest action https://github.com/mage-os/mageos-magento2/actions/runs/3374600139 should now work with forked repositories. Thanks for your patience.