[Magento 2.2 / 2.3] The iPay88 module shows the «Please agree to all the terms and conditions before placing the order» warning even if the terms and conditions checkbox is checked
codekipple opened this issue · 19 comments
Hi,
I'm attempting to upgrade a site using this module to magento version 2.2.2. After upgrading I'm having an issue where I cannot get past the checkout page.
After picking a payment option, checking the terms and conditions checkbox and clicking the 'Place Order' button it fails to re-direct me and just keeps showing the error message 'Please agree to all the terms and conditions before placing the order.' despite the fact that I have checked the terms and conditions checkbox.
I tried reverting the codebase back to the current Magento version the site is using (2.1.7) and the plugin again works as normal. I'm not sure when the functionality of the agreementsValidator code has changed between 2.1.7 and 2.2.2.
I've been looking into the issue but not having much luck so far. The part of Magento that creates the error message is vendor/magento/module-checkout-agreements/Model/Checkout/Plugin/GuestValidation.php line 104.
It may be only a problem with this site because of other 3rd party code rather than your plugin. I was just wondering if you have checked compatibility with Magento 2.2.2?
Thanks very much,
Carl
Provide the problem website URL.
I support only the paying customers.
A colleague has emailed you at admin@mage2.pro providing the website URL.
Yes, I have reproduced the issue with Magento 2.3.
I will fix it today.
It is not my module's issue.
It is a Magento 2.2 core issue: magento/magento2#11885
It is already fixed at 2017-12-19 in the 2.2-develop branch: magento/magento2#12401
So you need just to wait for the next Magento 2.2 release, or use the latest development code.
Today I have analysed the Magento team's fix above and I have noticed that it fixes only the PayPal module despite the fact that a lot of third-party payment modules are broken too.
So I have implemented my own fix for all my payment modules and I have included it to the 3.6.0 version of my mage2pro/core package.
Ah cool thanks Dmitry.
@codekipple , can you share the fix as I have used Payu module and that is also broken after upgrade to M2.2.3
Here is its URL, https://github.com/payu-india/PayUbiz_Magento/tree/ver2.x
I can implement the same fix for the Payumoney module for $150.
Ohhh, @dmitry-fedyuk can't you share the solution? I really appreciate if you share the same.
Banned.
Hi Dmitry, we have clients complaining because of the T&C blocking the checkout. They tend to think it's a third party module issue. Could you please confirm if this is indeed a Magento 2 core bug?
Provide me exact URL to your website.
I don't have client websites links, just dealing with M2 core: http://151.80.61.232/m224
Our payment method is the only one available on the payment page apart from the core ones.
This website does not use any of my modules.
Yes I know, just asking if you think this is a core M2 bug.
I can fix it for $200.
Ok it's something we can discuss, I will talk to our line manager. But in order to defend the case, I have to know if this a core M2 bug we are trying to find a workaround for, or if it a third party module issue.
Banned too.
Fuck off all non-payers.