magemonkeystudio/fabled

[Bug]: Changeclass Command Unbind / Unlearn Skills from other Classes

Closed this issue · 0 comments

Is there an existing issue for this?

  • I have searched the existing issues

Have you tried to reproduce this without OP?

  • I have tested without OP

Current Behavior

Using the "changeclass" command to switch to another class doesn't unbind/unlearn skills allowing skills from one class to still be triggered by another regardless of the skill trigger. This issue persists even through using "class reset" and is only fixed by re-logging or re-learning the skill after a reset and changing class some other way outside of "changeclass".

For example, if I have a class that has an ability which pushes enemies away when hit, and I change to a different class, enemies are still pushed away even though I am no longer that class.

Expected Behavior

If a user was to change class all previous triggers and skills should no longer be applied.

Steps To Reproduce

  1. Create at least two classes.
  2. Create two skills that use triggers besides casting such as on damage take, make sure it's something visually noticeable so that it can be seen if it triggers.
  3. Have the skill added to one of the two classes.
  4. Use that class and watch the skill trigger.
  5. Use /changeclass to change your class to a different one.
  6. Validate that the old skill still activates.
  7. Log out and log back in.
  8. Validate that the old skill no longer activates.

Environment

- Server Software: git-Purpur-2176 (MC: 1.20.4)
- Fabled Version: 1.0.0-R0.19-SNAPSHOT
- Codex Version: 1.0.0-R0.8-SNAPSHOT
- Plugins: FabledEnchantmentPack, FabledEnchants, Fusion, Mirage, Oraxen, PlaceholderAPI, PlugManX, ProtocolLib, Sapphire, spark Vault

latest.log

latest.log

# paste log here...

Anything else?

If you need anymore information feel free to comment and I'll get it for you!