Making new child in existing configurable overwrites sources for all existing children

Question

Making new child in existing configurable overwrites sources for all existing children

IanFiretoys opened this issue 2 years ago · 45 comments

IanFiretoys commented 2 years ago

Preconditions and environment

Magento version
Anything else that would help a developer reproduce the bug
magento 2.4.5-p1
have tested this on custom stock and default stock, was able to replicate on both

Steps to reproduce

open existing configurable product in admin
navigate to Configurations > current variations
Edit configurations
leave the attributes as they are and hit next
select an additional attribute value to increase the range and hit next
choose any option for "Quantity per source" (for this example, Apply single quantity to each SKU)
assign source and set qty of 1
next

Expected result

preview shows list of associated products, with the existing products intact below
new product shows quantity per source listed as 1
existing products show their current quantity per source as they were before this process

then you can hit generate products and save the configurable to continue

Actual result

preview shows list of associated products, with the existing products below
new product shows quantity per source listed as 1
existing products also show quantity per source listed as 1 - overwritten by the process of making a new child

if at this point you hit generate products and save out the config, these will be overwritten.

if "skip quantity at this time" remains selected, the source is removed from the other children entirely.

Additional information

as a workaround, you can untick all attribute values before selecting the new one at step 5, but then you need to manually add the existing child products back in once this process has completed.

Release note

No response

Triage and priority

Severity: S0 - Affects critical data or functionality and leaves users without workaround.
Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

Answer 1 · 2023-04-26T08:53:55.000Z

Hi @IanFiretoys. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release
For more details, review the Magento Contributor Assistant documentation.
Add a comment to assign the issue: @magento I am working on this
To learn more about issue processing workflow, refer to the Code Contributions.

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

Answer 2 · 2023-04-26T08:54:09.000Z

@magento give me 2.4-develop instance

Answer 3 · 2023-04-26T08:54:12.000Z

Hi @IanFiretoys. Thank you for your request. I'm working on Magento instance for you.

Answer 4 · 2023-04-26T08:58:03.000Z

Hi @IanFiretoys, here is your Magento Instance: https://45fd2e28e86fac7ab4edb6f902a44f60.instances-prod.magento-community.engineering
Admin access: https://45fd2e28e86fac7ab4edb6f902a44f60.instances-prod.magento-community.engineering/admin_6c01
Login: ccc17780
Password: 0f4a1677a833

Answer 5 · 2023-04-26T09:09:46.000Z

I have replicated on this develop instance, can confirm that stock is overwritten on default, but without MSI enabled, the source is not removed on "skip quantity at this time"

Answer 6 · 2023-04-26T09:19:10.000Z

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
5. Add label Issue: Confirmed once verification is complete.
6. Make sure that automatic system confirms that report has been added to the backlog.

Answer 7 · 2023-04-27T09:17:13.000Z

@magento give me 2.4-develop instance

Answer 8 · 2023-04-27T09:17:16.000Z

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

Answer 9 · 2023-04-27T09:21:34.000Z

Hi @engcom-Bravo, here is your Magento Instance: https://45fd2e28e86fac7ab4edb6f902a44f60.instances-prod.magento-community.engineering
Admin access: https://45fd2e28e86fac7ab4edb6f902a44f60.instances-prod.magento-community.engineering/admin_8514
Login: 376801df
Password: fd1e67abf092

Answer 10 · 2023-04-27T13:56:18.000Z

Hi @IanFiretoys,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.But,It is an Expected Behaviour of Magento.

Steps to reproduce

open existing configurable product in admin
navigate to Configurations > current variations
Edit configurations
leave the attributes as they are and hit next
select an additional attribute value to increase the range and hit next
choose any option for "Quantity per source" (for this example, Apply single quantity to each SKU)
assign source and set qty of 1
next

We are editing the entire Configurable Product for existing variations also, after increasing the attribute values range and we are giving quantity as Quantity per source it will take for existing variations also and it will again create new child products with new quantity because we have selected previous attributes values also.It is working as expected.

Kindly let us know if you are still facing any issue.

Thanks.

Answer 11 · 2023-04-27T14:15:30.000Z

@engcom-Bravo do you mean that overwriting the stock for all children in an existing configurable product is the desired outcome to adding any new attributes?

what would be the correct route for adding a new child to a configurable product without disturbing the existing stocks?

this is also inconsistent with how the weight and price are treated, which are far more likely to be the same as each other (and static) than the quantity. why is the one dynamic function the part that gets overwritten?

Answer 12 · 2023-05-02T20:05:19.000Z

@magento give me 2.4-develop instance

Answer 13 · 2023-05-02T20:05:22.000Z

Hi @maghamed. Thank you for your request. I'm working on Magento instance for you.

Answer 14 · 2023-05-02T20:10:18.000Z

Hi @maghamed, here is your Magento Instance: https://45fd2e28e86fac7ab4edb6f902a44f60.instances-prod.magento-community.engineering
Admin access: https://45fd2e28e86fac7ab4edb6f902a44f60.instances-prod.magento-community.engineering/admin_d594
Login: 2dcf9b40
Password: 5ffadd55ae2f

Answer 15 · 2023-05-03T15:40:01.000Z

@magento give me 2.4-develop instance

Answer 16 · 2023-05-03T15:40:04.000Z

Hi @maghamed. Thank you for your request. I'm working on Magento instance for you.

Answer 17 · 2023-05-03T15:44:35.000Z

Hi @maghamed, here is your Magento Instance: https://45fd2e28e86fac7ab4edb6f902a44f60.instances-prod.magento-community.engineering
Admin access: https://45fd2e28e86fac7ab4edb6f902a44f60.instances-prod.magento-community.engineering/admin_c71f
Login: 5985576a
Password: 13158015e7ba

Answer 18 · 2023-05-09T08:01:05.000Z

@magento give me 2.4-develop instance

Answer 19 · 2023-05-09T08:01:08.000Z

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

Answer 20 · 2023-05-09T08:05:17.000Z

Hi @engcom-Bravo, here is your Magento Instance: https://45fd2e28e86fac7ab4edb6f902a44f60.instances-prod.magento-community.engineering
Admin access: https://45fd2e28e86fac7ab4edb6f902a44f60.instances-prod.magento-community.engineering/admin_58c8
Login: ef519b34
Password: 6ced8755ee9e

Answer 21 · 2023-05-09T13:10:49.000Z

Hi @IanFiretoys,

Thanks for your update.

Verified the issue on Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

While editing the configurations we are editing previous configurations also so in that case it will overwrites existing children also.if we want to create new child products we need to untick the existing variations.It is woking as expected and it is expected behaviour of Magento.

Thanks.

Answer 22 · 2023-05-09T14:14:32.000Z

thanks @engcom-Bravo
when unticking the existing variations as you describe, they are removed from the parent and must be manually added back in. is that also expected behaviour of magento or should i open a new issue for that?

Answer 23 · 2023-05-16T13:30:58.000Z

Hi @IanFiretoys,

Thanks for your update.

We are considering this as feature request as this is existing behaviour of Magento.however this is a good feature to have.

Thanks.

Answer 24 · 2023-05-18T11:20:11.000Z

@magento give me 2.4.3-release instance

Answer 25 · 2023-05-18T11:20:13.000Z

Hi @IanFiretoys. Thank you for your request. I'm working on Magento instance for you.

Answer 26 · 2023-05-18T11:21:18.000Z

Hi @IanFiretoys, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

Answer 27 · 2023-05-18T11:23:38.000Z

@magento give me 2.4.3-p2 instance

Answer 28 · 2023-05-18T11:23:40.000Z

Hi @IanFiretoys. Thank you for your request. I'm working on Magento instance for you.

Answer 29 · 2023-05-18T11:24:08.000Z

Hi @IanFiretoys, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

Answer 30 · 2023-05-18T13:21:30.000Z

@magento give me 2.4.3-p2 instance

Answer 31 · 2023-05-18T13:21:32.000Z

Hi @IanFiretoys. Thank you for your request. I'm working on Magento instance for you.

Answer 32 · 2023-05-18T13:22:41.000Z

Hi @IanFiretoys, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

Answer 33 · 2023-05-25T13:37:28.000Z

@magento give me 2.4.3-p2 instance

Answer 34 · 2023-05-25T13:37:31.000Z

Hi @IanFiretoys. Thank you for your request. I'm working on Magento instance for you.

Answer 35 · 2023-05-25T13:37:55.000Z

Hi @IanFiretoys, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

Answer 36 · 2023-05-31T19:56:11.000Z

We're seeing the same issue. Has anyone found a solution to this?

Answer 37 · 2023-06-05T12:56:53.000Z

@magento give me 2.4-develop instance

Answer 38 · 2023-06-05T12:56:56.000Z

Hi @IanFiretoys. Thank you for your request. I'm working on Magento instance for you.

Answer 39 · 2023-06-05T13:02:07.000Z

Hi @IanFiretoys, here is your Magento Instance: https://45fd2e28e86fac7ab4edb6f902a44f60.instances-prod.magento-community.engineering
Admin access: https://45fd2e28e86fac7ab4edb6f902a44f60.instances-prod.magento-community.engineering/admin_2869
Login: 82510b8f
Password: 15eae1a0df76

Answer 40 · 2023-06-05T13:59:33.000Z

We're seeing the same issue. Has anyone found a solution to this?

apparently this is the intended functionality, but I don't recall it happening before the update to 2.4.5

I have been attempting to get an instance of 2.4.3-p2 but so far haven't managed it

Answer 41 · 2023-06-05T13:59:48.000Z

@magento give me 2.4.3-p2 instance

Answer 42 · 2023-06-05T13:59:51.000Z

Hi @IanFiretoys. Thank you for your request. I'm working on Magento instance for you.

Answer 43 · 2023-06-05T14:01:12.000Z

Hi @IanFiretoys, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

Answer 44 · 2023-06-05T14:01:47.000Z

@IanFiretoys you're right this is 100% a new issue on 2.4.5

There is also a related ticket open on the MSI repo: magento/inventory#3379

Answer 45 · 2023-06-05T14:08:49.000Z

@engcom-Bravo

can you confirm that this is still considered desired behaviour or a bug introduced in 2.4.5?