js-translation.json generation incomplete

Question

js-translation.json generation incomplete

AlexandreKhayrullin opened this issue 8 years ago · 19 comments

AlexandreKhayrullin commented 8 years ago

Preconditions

The Magento used is the "develop" branch.
PHP: PHP 7.0.10-1+deb.sury.org~xenial+1

Steps to reproduce

Install a locale pack on Magento (in this case, the locale is es_ES)
Set Magento in production mode.
Display a UiComponent on frontend using the installed locale

Expected result

The texts on the UiComponent are correctly translated

Actual result

The texts remain in English (or, rather, use the translation keys)

It seems that the generation of js-translation.json is inconsistent between developer and production modes.
In production mode, the JSON either contains very few values (see js-translation.production.json in the attached ZIP file) or just an empty array. In developer mode, the JSON contains a lot more strings (see js-translation.developer.json in the attached ZIP file) , enough to make the UiComponents translatable.

js-translation.zip

Answer 1 · 2017-04-02T12:45:38.000Z

I have the same issue with ar-json - not always Arabic files are generated in the JSON.

We expect that updating the CSV file should also update the Knockout JS files and Magento translation but it does not - this include local storage translation API

Answer 2 · 2017-04-04T08:15:35.000Z

Have the same issue with a clean Magento 2 install with a valid language pack. It's missing a lot of translations.

Answer 3 · 2017-04-13T15:04:39.000Z

I've tested and problem persists also in Version 2.1.6

I found the problem mostly in Checkout

Answer 4 · 2017-05-18T09:41:00.000Z

Same problem here. I used the workaround explained here: #2056 (comment)

Answer 5 · 2017-06-22T12:26:29.000Z

Also having trouble with this situation. Especially with the "Place order now" button. Can't get it translated. Not using CSV, not using complete language packs and inline translation doesn't work either.

Answer 6 · 2017-06-22T12:38:12.000Z

I just had it in developer mode too. This happens so often now that I remove the js-translation.json and run setup:static-content:deploy for my local language every time a translation doesn't work.

Answer 7 · 2017-06-22T12:40:11.000Z

We have created a work-around with a custom script which converts all .csv files to js-translation.json files and then manually rewrite requests to js-translation.json in our web-server to our custom files and it works everytime.

Answer 8 · 2017-06-22T12:56:40.000Z

@PascalBrouwers Thank you for the information, but that didn't work for me either. It's both in dev mode and in prod mode. I am wondering; does this issue occur in the checkout too? For me it's only in the checkout. Do you use a custom OneStepCheckout by for example Hungersoft or Magestore?

Answer 9 · 2017-06-22T13:28:18.000Z

We do have Magestore OSC, but it doesn't matter where the translation is when the entire js-translation.json file is empty :)

Answer 10 · 2017-06-22T13:33:00.000Z

Ah, i found out that the translations in our Magestore OSC broke because of $t('string') weren't the same as the data-bind in the span. I solved it by matching the data-binds (see screenshot). Maybe it might help you too.

Answer 11 · 2017-09-05T06:44:57.000Z

Same issue here, $t translations work fine in developer mode, but fails in production mode

Answer 12 · 2017-09-05T07:49:17.000Z

@cjohansson please can you share this solution of making a custom json file as I was considering doing the same. I would really appreciate it - is it a module or snippet that you can opensource?

Answer 13 · 2017-09-05T11:25:19.000Z

rm pub/static/<area>/<vendor>/<theme>/<lang>/js-translation.json
setup:static-content:deploy <lang> --theme=<vendor>/<theme>

generated proper js-translation.json for <lang>, and translations work fine.

Answer 14 · 2017-11-17T12:03:48.000Z

@AlexandreKhayrullin, thank you for your report.
We've created internal ticket(s) MAGETWO-84070 to track progress on the issue.

Answer 15 · 2018-07-19T08:03:59.000Z

Any update on this issue?

Answer 16 · 2019-02-22T05:03:04.000Z

A problem in 2.3 it seems.

Answer 17 · 2019-04-03T08:01:20.000Z

I'm working on a Persian language project and have same issue experience.
Magento 2.2.7 #10860

Answer 18 · 2019-12-27T09:32:03.000Z

Hi @engcom-Bravo. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
2. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
3. If the issue is not relevant or is not reproducible any more, feel free to close it.

Join Magento Community Engineering Slack and ask your questions in #github channel.

Answer 19 · 2019-12-27T11:30:56.000Z

Hello @AlexandreKhayrullin
Unfortunately, I cannot reproduce this issue by steps you described on 2.4-develop
Please feel free to comment, reopen or create a new ticket according to the Issue reporting guidelines
if you are still facing this issue on the latest 2.4-develop branch. Thank you for collaboration.