magento/upward-php

[BUG] /img/resize Requests Return 404

Closed this issue · 0 comments

  1. There is a difference between request.url.pathname. Node docs appear to indicate pathname should not contain query params, but upward-js appears to have them. upward-php does not have query params in pathname, hence why we’re getting 404's (the pattern isn’t matching with just /img/resize/480).
  2. If I make upward-php pathname match upward-js, this pattern still doesn’t appear to match. I’m not sure what the optional third selector is doing, and just wanted to verify the second selector should be grabbing the url param (although it’d probably be better just to use request.url.query.url).

Pattern: ^/img/resize/(\d+)w/(.*())
Value: /img/resize/480?url=%2Fmedia%2Fcatalog%2Fcategory%2Fbeachy.jpg

Expected Outcome: Confirm expected behavior with @zetlen and implement solution that works in both upward-php and upward-js.