magiclabs/magic-js

Bug Report: Endless Cookie Rendering Loop

Adebesin-Cell opened this issue ยท 5 comments

โœ… Prerequisites

  • Did you perform a cursory search of open issues? Is this bug already reported elsewhere?
  • Are you reporting to the correct repository (magic-sdk)?

๐Ÿ› Description

Upon initializing the Wagmi connector into my project, I noticed a peculiar behavior related to cookie rendering.

๐Ÿงฉ Steps to Reproduce

  1. Integrate the Wagmi connector into the project.
  2. Initialize the Wagmi connector within the codebase.
  3. Observe the rendering behavior of cookies.
  4. Notice the continuous rendering of cookies without halt.

๐Ÿค” Expected behavior

I expected the cookies to render appropriately upon initialization and to cease rendering once initialized. There should be no continuous loop of cookie rendering.

๐Ÿ˜ฎ Actual behavior

The cookies enter an infinite rendering loop, continually rendering without cessation. This behavior triggers an error marked with number of times it has rendered, indicating that the cookies have been rendered an excessive number of times. Consequently, this error warns that third-party cookie functionality may be blocked.

๐Ÿ’ป Code Sample

https://stackblitz.com/edit/stackblitz-starters-bbb65e?file=app%2Fpage.tsx,app%2Fconfig.ts,package.json

Screenshots

Screenshot 2024-03-25 at 5 38 25 PM

๐ŸŒŽ Environment

Software Version(s)
magic-sdk 18.3.0
Browser Vivaldi
yarn >=1.22.0
Operating System Mac OS Ventura 13.1 (22C65)

This seems to be a issue on almost all sites that has magic login integrations

image

image image image

Yep, we're experiencing this issue as well, we recently upgraded https://github.com/magiclabs/wagmi-magic-connector in our project from 1.1.5 to 2.0.0, which it seems also comes with a magic SDK version upgrade.