magma/S1APTester

chore: non-inclusive language

Closed this issue · 2 comments

Your Environment

  • Affected Component: S1APTester

Describe the Issue

The Snyk console hosted by Linux Foundation at https://security.lfx.linuxfoundation.org/#/a092M00001IkV6eQAF/non-inclusive-language has flagged usage of terms which may alienate developers.

To Reproduce

Search the repo for these terms:

  • whitehat
  • slave

Expected behavior

  • "secondary" instead instead "slave"

Screenshots

image

Additional context

The term "insane" is reported by Snyk but no longer exists in the code.

The term "whitehat" is only in a URL, and the URL points to Facebook, which is now an obsolete reference and needs to be fixed anyway.

New developments:

  1. The S1AP code needs to reflect that I2C "slave" is official language from specification and just changing it is not a solution. We should wait for the the spec to change.
  2. We should have a policy to prevent new adoption of non-inclusive language. This can be based on https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=49decddd39e5f6132ccd7d9fdc3d7c470b0061bb or https://docs.zephyrproject.org/3.1.0/hardware/peripherals/i2c.html . It can be on the wiki.