magnars/optimus

Can't minimize bootstrap theme with external resource

vbauer opened this issue · 4 comments

vbauer commented

Hello!

I downloaded theme "Superhero" from http://bootswatch.com and Optimus thrown an exception on external resource in css file (bootstrap.css):

@import url("//fonts.googleapis.com/css?family=Lato:300,400,700");

If you remove this line it will be compiled.

PS: It is not very major issue for me, but maybe for somebody..

magnars commented

Thanks for the report! I'll have a fix in for this this evening.

vbauer commented

Thanks for the quick reply, you make awesome project!

magnars commented

Thanks, glad to hear that. Please do open more issues as you find them. I want this project to be very solid. :-)

Looking at the code, I realized that I had put the warning there for a good reason. But I had also messed up the error message, so you got a nonsensical warning.

That should be better in the next version. In the meantime, I'll keep the error message as is. Basically: Import of external URLs is strongly adviced against. It's a performance killer. In fact, there's no option to allow this. Use a link in your HTML instead. Open an issue if you really, really need it.

magnars commented

0.14.3 released with better error message.