When editing google slides, firefox gives me a warning that Video Speed Controller (Magnus Fork) is slowing down my browser
Opened this issue · 6 comments
No clue what could be causing it. I get a big spike of lag, followed by the warning flashing up for a sec, and then everything runs smoothly. I blacklisted docs.google.com to see if that'd help, but the lag still occurs.
Seems to also happen when doing a google search. Let me see if I can figure out why it happens, sorry to take so long to get to this.
Weirdly, I can reproduce on my browser profile, but not in a new test one with no other extensions involved.
It seems to potentially be a problem with the way the extension interacts with the "translate webpages" extension. Do you have that one too? not true, you have to log in to google to reproduce
Somehow google gets in an infinite loop of adding divs and spans and other random html elements which look like they have some structure, but I don't know what it is.
Every time the extension notices it adds an element, it will check the element to see if there is a video in it. This is intended behavior, and is important, for example, on reddit where you want to continue scrolling to new stuff.
There is nothing the extension is doing to trigger code that would add more stuff to the document. Nevertheless, google seems to only enter an infinite loop while the extension is active.
I really don't understand this bug.
Here's the URL I was using to reproduce it: https://www.google.com/search?q=the+ice+beneath+my+feet+with+every+climb+my+life+complete+like+birds+flying+high+weightlessly+song
That url doesn't seem to cause lag for me. I haven't used google docs or google search in a while either, so I'm not entirely sure if google's just fixed this in the background or if I'm just unable to recreate it.
I've been able to reproduce this bug on the Google Travel site (https://www.google.com/flights), where selecting the calendar to choose dates causes my Firefox to run significantly slower and the same warning banner to appear. I was using the original Video Speed Controller extension and just recently switched to this version, both of which have the bug.
I haven't noticed this on the google search page, and I do not use google slides so I am not sure if it's present there as well.
I added the following to the blacklist and it seems to be working, but there will be some side effects with it not working on Google Drive
/(.+)google\.com(\/.*)$/
/(.+)google\.com(\/.*)$/gi