majgis/ngify

Parse error in HTML causes ngify to exit

ctucker opened this issue · 3 comments

ctucker commented

If invalid (not-well-formed) HTML content is passed to ngify, it will throw an exception rather than emitting an error. This causes e.g. watch processes to exit rather than handle the error gracefully.

For example, attempting to ngify something like:

<div

will cause htmlminifier to throw, which will just bubble up and cause the process to exit.

majgis commented

Thank you for bringing this issue to my attention. I will work on resolving this issue as soon as time permits.

ctucker commented

I'll have a PR for you in about 5 minutes. :-)

On Mon Jan 12 2015 at 8:54:06 AM majgis notifications@github.com wrote:

Thank you for bringing this issue to my attention. I will work on
resolving this issue as soon as time permits.

—
Reply to this email directly or view it on GitHub
#9 (comment).

majgis commented

@ctucker , thanks for your PR. I just published v0.1.2 to npm with your changes.