makandra/spreewald

Modernize time steps

judithroth opened this issue · 2 comments

judithroth commented

The time steps in Spreewald rely on the Timecop gem.
Since 4.1 Active Support has its own time travel functionality, that seems to cover all the usecases that Spreewald offers (travel, travel_to, freeze_time. Since almost all our projects already include Active Support we should switch to that.

👍 for switching to Active Support
👎 for keeping Timecop

triskweline commented

We still have a few projects in active development that are on Rails 3.2 LTS. You cannot upgrade ActiveSupport without upgrading Rails. Because of this it's a 👎 from me.

  • 👍1
foobear commented

We've discussed this and will implement as follows:

  • When Timecop is available, we will use Timecop
  • When Timecop is unavailable, but ActiveSupport time helpers are available, we will use them
  • If neither is available, time steps will be undefined. This is similar to the current behavior where steps are undefined when Timecop is unavailable.