makerdao/market-maker-keeper

Do not cancel EtherDelta orders if they move away from the centre

Opened this issue · 1 comments

If price moves in one direction, we need to cancel the orders that get too close to the centre, but in the case of EtherDelta there is really no need to cancel the ones on the other side that move further from the centre. They will expire anyway, if somebody takes takes them before that we will earn more than we originally planned to, and - what is most important in case of EtherDelta - existing orders to not "eat up" from the deposited balance so they do not block us from placing new orders. I.e. same deposited money can be used for placing multiple orders.

This strategy could potentially save us around 50% gas.

We do not maintain the EtherDelta keeper anymore. Closing.