makeup/makeup-js

makeup-menu-button: SR announces value twice in list items with Icons

Closed this issue · 0 comments

For menu button with value type icon, SR announces text twice when selected. This is because the attribute changes were directly applied on the list item instead of creating a cloned copy.

const icon = e.detail.el.querySelector(this._options.iconSelector);

case "icon":
        icon.setAttribute("aria-label", content);
        icon.removeAttribute("aria-hidden");