bootboxjs/bootbox

Bootbox 4.3.0 (next minor release) task list

makeusabrew opened this issue · 13 comments

makeusabrew commented

core

  • reimplement icon support
  • add left/right arrow support for button focus (#137)
  • set default locale based on html lang attribute
  • allow user to specify which button has focus in options argument
  • allow hoisting of ok, cancel and confirm button declarations up to root level options object on wrapper methods
  • add official support for radio button options in prompt (#189)
  • allow width and height options (#190)
  • allow Bootstrap 3.1 size parameter to be specified (#228)

docs

  • add FAQs; async / sync, browser support, dependencies
  • add quick migration guide from v3.x to v4.x
ducman commented

Unsure if this is already added but with the new bootstrap 3.1.0 (I believe), they added the ability to make small or large dialog. Can you add it in the release as well?

makeusabrew commented

Someone's already very kindly submitted a PR with that in. I'll add it to the list so people know it's coming :)

DaSchTour commented

Could you maybe release a 4.2.1 with the the size parameter? This would be really great!

RWOverdijk commented

+1 on what @DaSchTour asked. I came here to ask for that as well.

Xenopotamus commented

I am running into a few issues with v4.2 running on Bootstrap 3.2.0. (also happens with BS 3.1.1) Basically when calling bootbox.dialog while a Bootstrap modal window is already open... I am having the following two issues:

  1. The first modal window does not get dimmed out. I managed to fix this when 2 or more regular Bootstrap modal windows are opened by listening to the shown.bs.modal event and manipulating the z-index of the backdrop, but with Bootbox I am having an impossible time detecting when the Bootbox dialog is actually displayed. The shown.bs.modal event does not appear to fire when Bootbox is displayed.
  2. When closing the Bootbox alert while a modal window is opened behind it, the 'modal-open' class is removed from the HTML body, resulting in a scrollbar that allows the main background to be scrolled instead of the modal window. Again, I have fixed this with regular bootstrap modal windows by listening to the shown and hidden.bs.modal events and adding/removing a class from the body tag... but with Bootbox I am having no such luck. It all seems to be related to being unable to detect when a Bootbox alert or dialog is shown or hidden.

Any chance of adding better support for Bootbox alerts on top of modal windows in a future release? For now I am considering disabling the backdrop to see if that avoids some of the issues. Thanks!

makeusabrew commented

Hi all,

Sorry for ignoring this for so long; will try and carve out some time to look at these requests ASAP.

Nick

tarlepp commented

btw, imho it would be better if you can specify custom class to modal content. With that users could just simply add their own CSS class which has height and width specified. And basically this aproach will cover default bootstrap 'lg' and 'sm' handling as well.

Another idea is just to specify width, and make small js snipet to increase height to maximum value that can be used (I have uses that aproach a lot in my apps with bootbox.js).

makeusabrew commented

4.3.0 just released; see the release tag page for full details.

makeusabrew commented

Closing this; will re-create with outstanding issues for 4.4.0

schelebyan commented

Would you please allow dismissing the modal by clicking the background?
It would just be removing the following line:
options.backdrop = options.backdrop ? "static" : false;

Or leave that as is by default and have a separate option that will allow for background click dismissal.

Thanks

RWOverdijk commented

@makeusabrew Where's the 4.4.0 milestone? I wanted to add a suggestion but I can't find it :)

makeusabrew commented

@schelebyan will hopefully get this scheduled for 4.4.0