Allow bundle to install in SF 4.0 ?
Closed this issue · 4 comments
tabbi89 commented
Is there any reason why we couldn't add SF 4.0 dependencies ?
"symfony/http-kernel": "^2.8|^3.0|^4.0",
"symfony/dependency-injection": "^2.8|^3.0|^4.0",
?
maks-rafalko commented
Thank you, I will look into this in the next few days. Feel free to submit a PR
tabbi89 commented
Hi I just wanted to submit PR but I've realized that there are no tests. Maybe it would be wise to add a functional test with whole bundle setup something similar to https://github.com/Behat/Symfony2Extension/tree/master/testapp ?
maks-rafalko commented
Having a functional test definitely would be a great thing
maks-rafalko commented
Implemented in #9