Allow bundle to install in SF 4.0 ?

Question

Closed this issue 6 years ago · 4 comments

Is there any reason why we couldn't add SF 4.0 dependencies ?

"symfony/http-kernel": "^2.8|^3.0|^4.0",
"symfony/dependency-injection": "^2.8|^3.0|^4.0",

?

Answer 1 · 2018-02-04T08:36:37.000Z

Thank you, I will look into this in the next few days. Feel free to submit a PR

Answer 2 · 2018-02-04T21:25:40.000Z

Hi I just wanted to submit PR but I've realized that there are no tests. Maybe it would be wise to add a functional test with whole bundle setup something similar to https://github.com/Behat/Symfony2Extension/tree/master/testapp ?

Answer 3 · 2018-02-05T05:20:22.000Z

Having a functional test definitely would be a great thing

Answer 4 · 2018-03-12T20:25:27.000Z

Implemented in #9