mallocator/Elasticsearch-Exporter

exports.storeData retry logic cannot work as expected

eboyme opened this issue · 2 comments

The value of retries in the function storeData is always 0 because of the below statement (line 578-580 in es.js):
if (!retries) {
retries = 0; // it should be 1, right?
}
After changing the default value from 0 to 1. It works as expected. Please take a look if you have time. I guess infinite retries are not your expectation. :)

Yeah you're right. Thanks for pointing that out.

You are welcome.

On Tue, Oct 14, 2014 at 9:53 AM, Ravi Gairola notifications@github.com
wrote:

Yeah you're right. Thanks for pointing that out.


Reply to this email directly or view it on GitHub
#80 (comment)
.

Regards,
Yi Bo