Share icons in article and comments menus too big
Closed this issue · 5 comments
The menu icons in menu_comments.xml are different sizes; the share icons from action_share are bigger than the normal size for a menu icon. They should be 24dp (guidelines), but appear to be 36dp instead. The icons for action_article and action_bookmark and the up button are the correct size.
I tried fixing the share button by adding android:icon="@drawable/ic_share" (to at least set the share icon to the correct size, as the ic_share draw able is the correct size) to the item, but I didn't see any change as a result.
Got help from @Chainfire and tried: http://stackoverflow.com/a/24472038 & http://stackoverflow.com/a/21922282. The icon changed, but it got for some reason it scaled up and became blurry, so neither worked (I tried with your @drawable/ic_share and the built in @drawable/abc_ic_menu_share_mtrl_alpha).
I think android.support.v7.widget.ShareActionProvider just hasn't been updated to meet the new guidelines.
Possible solution: switch to another share implementation. I wouldn't mind attempting to handle this; it would be a good learning experience for me. Any suggestions/thoughts?
Great client, by the way. Installed it yesterday and I've really been enjoying it. Seems very well written, too.
I had been using a different HN client for some reason until your reply.
Anyway, the share icons look good to me now. I don't notice any difference in size.
Oh, I've switched back to it. The only thing bugging me now is the links
not showing.
On Sun, Dec 27, 2015, 9:41 AM David González notifications@github.com
wrote:
thanks @ethanmad https://github.com/ethanmad! I hope new updates will
convince you to use Yahnac again! :)—
Reply to this email directly or view it on GitHub
#23 (comment).