Adding a new view
Opened this issue · 29 comments
There is a custom view of RCB in the Aeon MQ7 skin called Panel. However Aeon MQ7 is only compatible with Kodi Krypton and the Leia mod doesnt have these RCB skin files. Furthermore these RCB skin files in Aeon MQ7 only work properly with RCB v1.3 which is pretty much outdated.
However in my opinion its a fantastic view so I wondered if we could just apply this view in the official RCB views.
On the left-/topside corner there is actually a screenshot/trailer displayed. However my installed RCB version is higher than v1.3 so the installed skin files dont work properly.
Sorry for posting this here but I wanted to let you Kupo91 know that I found the fix to allow the viewmode to save and load properly on kodi v18 RBC v 2.2.3. Just add the extra line of code and it works.
also if you want I can try and post a panel view you can add to your skin but replacing one of your view modes. Just let me know what the view number is.
I thought you would want to know. If someone knows how to add this to the real code after checking that it works that would be great. Thanks for any help.
Ok it took forever but I did find a fix and I just wanted to share.
In location
kodi\addons\script.games.rom.collection.browser\resources\lib\gui.py
Just change this
#reset view mode
viewModeId = self.Settings.getSetting(util.SETTING_RCB_VIEW_MODE)
if viewModeId != None and viewModeId != '':
xbmc.executebuiltin("Container.SetViewMode(%i)" % int(viewModeId))
To this
#reset view mode
viewModeId = self.Settings.getSetting(util.SETTING_RCB_VIEW_MODE)
if viewModeId != None and viewModeId != '':
xbmc.executebuiltin("Container.SetViewMode(%i)" % int(viewModeId))
xbmc.executebuiltin("Container.SetViewMode(%i)" % int(viewModeId))
I know this should not work but give it a try. Just Doubling that line got it to work for me.
I hope this helps someone. Good luck
Thank you I've already seen this fix but I couldnt decide what view I want to have yet. It was fantastic if there was a way to implement the panel view. These are the RCB skin files of Aeon MQ7:
I think the code for the panel view is saved in script-Rom_Collection_Browser-main.xml
but it only works with Kodi Krypton. I dont know why it doesnt work with Leia but maybe the code still helps in some way. I already tried it by myself but I have no clue about xml language
Sorry I can not make it look exactly like the panel view without the id 62 panel view script from that skin. However I am sharing my skin with you just copy the files over and select it from the skin option. Its called Confluence Grid. Let me know if there is a problem with it. Also please let me know if my view mode fix worked for you.
Edit I downloaded the skin. Working on it. if you still want it.
The view mode fix doesnt work for me. I get an error:
view mode fix error.zip
In the panel view there is a strange on/off button on the screen. The button is from the Aeon MQ7 skin but I dont know what it is doing there. Instead of the game cover in the left-bottom-corner there should be the games screenshot and the description is missing. I attached two Aeon MQ7 skin files about the Panel view. Maybe one of them is the script file that you mean:
panel view.zip
Thanks for testing my code. To fix the my skin just exit out of kodi and start it again should get it to load the textures correctly. I will work on making a skin like the Aeon skin. Please try this fix for the view mode not saving and let me know if it works. Thanks.
View Mode Fix.zip
Cool I'm looking forward to your skin :) Your gui file fixed the view mode issue!
Thanks Kupo91
ok it is not perfect but here it is. just add these file to your confluence skin. I could not find the correct background and I don't understand why there is not label's but it works. I replace id 53 with this panel one. if you wish to change back just extract the rar file and it will go back to the old confluence skin.
Changes to add Panel to Confluence skin.zip
Thanks a lot @Royusmc that was a big step forward. However there are still some issues which I want to show you. Thats how the view looked like when I extracted your zip file:
I changed the background to the one I used to have:
And then I compared it to a screenshot I made with Aeon MQ7 Skin, RCB v2.1.3
So first thing is that its a bit hard to read because in the original skin there is something like a shadow on the background that makes the font better to read. Its not a really clean solution but I solved this by taking a screenshot of the shadow screen and used the screenshot as new background. So I had this:
If you now compare the final screenshot with the screenshot from Aeon MQ7, RCB v2.1.3 there are some differences.
- I think fixing the positioning of the box fronts might be the easiest thing. Apparently there is a maxwidth and a maxheight in the original so the space between the boxfronts is always the same.
- In this new version there is no game title, no screenshot and no tags like year, genre and developer
- In the new version there is this panel word which shouldnt be there
Could you please take another look if you can fix that?
Sorry after post the new Confluence skin I remembered that I don't use any of the filters so I removed the code to go to the filters. My kodi is setup with many RBC renamed to NES, SNES, GEN and so forth. So I start them from the home screen. So I have no need for filters. But I have fixed that problem and here it is. If there is anything you want changed just let me know. The picture dose not show the way it works so I don't know if there is names under the box art are any labels. Also if you find the background I can add it. Well here is the fix one.
Changes to add Panel to Confluence skin + fixed not showing filters.zip
Sorry I see what you are taking about. I will fix these problems and post it when I am done.
Well here it is a little better. Don't forget about the new media pics as well. I hope you like this one better.
New Panel Confluence 01.zip
Hi, what do you mean by new media pics? Anyway it looks close to the original, very nice. However do you think you can still add the screenshot in the left-topside-corner? And maybe making the game title a bit bigger?
Well I thank this is about right. I added clear logo's also.
The new media pics just meant that I added files to the media folder in the skin folder as well. But it looks like you figured it out on your own.
This is great Royusmc finally its showing screenshots again. I didnt see them for so long. Almost one year.
Now its really close to the original:
Could you maybe try to fix the aspect ratio of the screenshots, make the game title font still a bit bigger and place the different elements in the position that they have in the original? And I have something like a feature request. Something what the original doesnt have. Could you maybe add the platform of the selected game in the left bottom corner. Some other views have this too and I like that.
Anyway you already did so much for me, thanks a lot. You are a hero
Here are the fixes you asked for.
New Panel Confluence 03.zip
Thank you Royusmc, its looking good :) maybe you could still adjust some positions for me?
Can you
- make the game title a bit bigger and push it a bit more to the left so it is on the same height as the platform on the bottom side?
- reduce the description lines -1, so theres a bit more space between description and platform
- increase the space between the game rows a little bit so there isnt so much space below the last game row
- add a decent border to the game screenshots, maybe like the original
- change the color of the selected game from blue to white
- and make the transition of the black line above the first game row a bit softer (only if possible)?
Well I thank we got it right this time.
New Panel Confluence 04.zip
I love it :) only the game title is still a bit too small. If you could make it bigger it was perfect
Sorry I tried other fonts but none worked. So it is what it is. But if you want you can try yourself it is on line 1040 of script-Rom_Collection_Browser-main.xml. Good luck
Hm its not possible to change the fontsize?
Only the font sizes that work with the font that it uses will work. This was the largest one I could get to work. font35_title was the biggest one. trying just font35 does not work. When I look at the font for the skin it shows font sizes of 12,18,24,36,48,60,72 but they don't work as you can see 35 is not even on there. So if I do find one that works I will post it for you. Good luck
Okay maybe someone will find a solution for this but anyway its already a fantastic work that you made. Thank you for this.
I just noticed a small bug. In some games the text alignment from the publisher line is wrong. However in most games its correct. Maybe you have an idea why? Its not a big deal so if not its okay.
Thanks @Royusmc! I will see if I can include this new view to RCB. If you have more views or changes to RCB that I could include just let me know.
Hi Malte,
schön, dass du wieder da bist. Ich schreib das jetzt mal kurz auf deutsch, weil mein englisch so scheiße ist.
Weißt du vielleicht wie man die Schriftgröße verändern kann? Wär toll, wenn der Spielname etwas größer wäre. Der sieht etwas mickrig aus.
Und noch ein kleiner Bug der mir in der Ansicht aufgefallen ist:
Wenn man ein Spiel startet und nach dem spielen wieder in RCB landet, ist nicht mehr das Spiel ausgewählt, das man gespielt hat, sondern immer ein Spiel 2, 3 Einträge dahinter.
Das hat jetzt alles keine Priorität, aber vielleicht kannst du mal in einer freien Minute drüber schauen. Ich weiß jetzt auch nicht wie kompliziert oder unkompliziert das ist.
Hi Kupo,
your english seems to be as good as mine :). I would like to keep "public" disussion in english, so that everybody is able to read them. You can PM me or write in the german forum if you would like to continue in german.
I will look into your issues when I start to work on this panel. As Royusmc already stated, we are limited to the fonts that the skin provides. But I will check again if there are bigger ones available.
Ok, thanks for your effort.
I just thought that the font size can be easily increased because the game title in the original view is bigger too. How is this possible? Are there different commands in both skin files?
Is it possible to change the font colour of year, genre and publisher? (Just the words, not the part behind ":")
I have another issue. Yesterday evening I scrolled through the addon settings to look what skins are available. I saved this view as Aeon MQ7 because I didnt want to change the existing skins.
By scrolling through the addon skins I stopped at Arctic Zephyr and then pressed cancel to exit the settings. But how it seems it didnt cancel the skin change but used the one I had selected.
So when I started RCB today I had this other skin and after changig it back to my old skin the border of my screenshot isn't black anymore but white.
Can you fix this?
The border somehow fixed itself. Restarting RCB didn't work but maybe rebooting kodi did the trick.
However "Cancel" seems to have the same effect as "OK" in addon settings. I also tested it in Kodi Estuary (just to be sure that there is no Aeon MQ7 skin files that causes this issue).
And I also noticed that "Clean Database" doesn't work anymore.