mamboitaliano21/subdownloader

Can download wrong subtitle if more than movie share same hash and size

Closed this issue · 3 comments

When more than one video share the same hash and size, the search for your
subtitle can return wrong subtitle, as the download choice is done by
rating ATM.

Possible new subtitle checking before download:
- compare video/movie name with subtitle results, and if a match is found,
download that subtitle (dont check rating)
- if no subtitle name matches the video/movie name, use rating to make
download choice

Original issue reported on code.google.com by set...@gmail.com on 15 Mar 2008 at 2:02

Another solution is to show a list with all the possible subtitles found for 
that
language.
Media Players calling subdownloader can use an extra parameter to tell that 
they want
only 1 subtitle(following your recommendations before)

Original comment by capiscuas@gmail.com on 15 Mar 2008 at 3:49

Original comment by set...@gmail.com on 16 Mar 2008 at 1:21

  • Changed state: Fixed
BTW, what do you mean with "one video share the same hash and size", that's
technically imposible from a hash + size, that means that the videofile are the 
same.

Original comment by capiscuas@gmail.com on 24 Mar 2008 at 6:09