Change name of OfferLogic and LiquidityProvider in SDK to match Solidity
peterMangrove opened this issue · 1 comments
Is your feature request related to a problem? Please describe.
The naming of OfferLogic and LiquidityProvider in the SDK and Solidity does not seem to match very well. Since an ILiquidityProvider from solidity is the same as an OfferLogic in the SDK. This is going to be the source of some confusion.
Describe the solution you'd like
Rename the classes in the SDK to match the solidity code. If we have any helper classes like LiquidityProvider in the SDK that is not a Solidity contract/interface, then come up with a new fitting name.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The situation around LiquidityProvider in the SDK is not good at the moment, however, the issue here is not correct anymore. OfferLogic in the SDK and solidity does correlate.