`LiquidityProvider`'s function `computeAsk/BidProvision` is incorrect when underlying logic is `MultiUser`

Question

`LiquidityProvider`'s function `computeAsk/BidProvision` is incorrect when underlying logic is `MultiUser`

jkrivine opened this issue 2 years ago · 2 comments

Describe the bug
In multi User contract, the available balance for an update might be stored in the offerData map as free_wei. Currenlty getMissingProvision assumes the balance is always 0 for multi user contracts.

Answer 1 · 2023-01-26T19:54:31.000Z

It appears getMissingProvision has been revised - @jkrivine is this issue still relevant?

Answer 2 · 2023-05-24T07:28:50.000Z

Fixed by #1290 . As Espen mentions the code had previously been revised to take Forwarder(multi-user) contracts into account, but still did not account for provision locked in "naked offers" without contract code. That is now fixed.