`OfferLogic`'s `approveToken` and `approveMangrove` doesn't take overrides as expected
jkrivine opened this issue · 1 comments
jkrivine commented
Describe the bug
OfferLogic.approveToken("aDAI", overrides); ignores the overrides.
Instead one should do:
approveToken("aDAI", {}, overrides); which is counter intuitive
This is due to ts not handling two optional arguments properly
jkrivine commented
Same problem applies to approveMangrove. In general all API's approval should be modified to avoid this issue.