mangrove.js: add unit tests for `semibook.estimateVolume`
adhusson opened this issue · 3 comments
adhusson commented
The new estimateVolume simulates the workings of mangrove's marketOrder -- we should add tests that ensure the two routines are equivalent, modulo the 2^256-1 ceiling in solidity.
espendk commented
A number of tests of estimateVolume have been added here: https://github.com/mangrovedao/mangrove-ts/blob/b2d781c0768ef6cfe288165d10586f2deae4d313/packages/mangrove.js/test/integration/semibook.integration.test.ts#L402-L665
Are these sufficient or is more/something else needed?
peterMangrove commented
@espendk Can this be closed, it seems tests has been added?