mangrovedao/mangrove.js

Handle the case of a multiMaker contract for getMissingProvision()

johanleroch opened this issue · 4 comments

johanleroch commented

Describe the bug
When I ask for the missing provision with getMissingProvision() function, the returned provision is not sufficient to make resting orders. I got this error message MultiUser/newOffer/NotEnoughProvision. Here the details

The comment here suggests that the case is not handled for mangroveOrder tx (which is a multiMaker contract).

johanleroch commented

⚠️ Note: It's not blocking for me at the moment, @jkrivine suggests me to put more provision to make the TX work. (I doubled its value)

espendk commented

I believe this has been fixed as the multi-maker comment is no longer in the code. Do you agree @jkrivine ?

peterMangrove commented

@johanleroch Is this still an issue for you or is it fixed?

jkrivine commented

This is good now, the old computation has been replaced by the proper one.