warning: 'operationType' may be used uninitialized in this function [-Wmaybe-uninitialized]
Closed this issue · 6 comments
/build/src/mhwd/mhwd/mhwd.cpp: In function 'int main(int, char**)':
/build/src/mhwd/mhwd/mhwd.cpp:818:84: warning: 'operationType' may be used uninitialized in this function [-Wmaybe-uninitialized]
config = mhwd::getDatabaseConfig(&data, (*iter), operationType);
^
Linking CXX executable mhwd
maybe we should look into it ...
It would be easy to understand the code, if the code was commented, thats my opinion.
Good documentation in code, leads to easy contribuition of fixing issues, if an issue happen.
Not commented, but more readable (better structure). That's why I began working on the development branch. It is already solved there.
@december0123 : can you point me the commit actually fixing it in development branch? Also what is the status. Can we merge your code to the stable branch or do you still do some fixing?
I won't be able to tell you which commit fixed this, because it got fixed when I was moving everything around.
As for the status: I have a lot of work lately and I had to slow down. As long as it's stable (I hope people are actually testing it) I see no reason not to merge it with master and then I can continue working on the development branch (there is still work to be done). The thing is Kirek asked me to create a library for MSM and I haven't had time to do it yet. I think he can just use old source for now, though (please ask him).
I've been testing mhwd-dev in live isos and didn't have any problems (VMs, and a laptop with hybrid graphics). MSM works with mhwd or mhwd-dev.
Ok. I'll merge it now.