manjaro/pacman-mirrors

Bugfix

Closed this issue · 3 comments

fhdk commented

@philmmanjaro
I have discovered a potential bug.

It would manifest itself in not parsing content correct from the keys in pacman-mirrors.conf which supply a possible list.

  • OnlyCountry
  • Protocols

It would only manifest if the keys was manually edited and space is used as separator.
The bug is fixed with commit 6b6869a

When you have a minute - I am in the need of an update to the package.

fhdk commented

@philmmanjaro
Please hold the horse - I have another thing

fhdk commented

Even though I do a lot of thinking - I forget something obvious - which just flashing my mind now

  • Improvement: adding checks to --proto using the choices=[] for argparse
  • Improvement: adding branch to --set-branch no dependency on --branch using the choices=[] for argparse
  • Fix: Issue where values from configuration was not parsed correct.
fhdk commented

Better leave as is to better tested - I tend to get too eager