manrajgrover/football-cli

Bug: Handle multiple standings response in League standings

manrajgrover opened this issue · 1 comments

manrajgrover commented

Description

Case where there are multiple groups in standings is currently not handled. This needs to be fixed.

Versions

  • NodeJS version (if applicable): NA
  • Football CLI version: 0.14.0

Error

/Users/manrajsingh/Github/football-cli/helpers.js:222
      for (let team of group) {
                       ^

TypeError: group is not iterable
    at standings (/Users/manrajsingh/Github/football-cli/helpers.js:222:24)
    at Request.request [as _callback] (/Users/manrajsingh/Github/football-cli/cli.js:197:9)
    at Request.self.callback (/Users/manrajsingh/Github/football-cli/node_modules/request/request.js:187:22)
    at Request.emit (events.js:159:13)
    at Request.<anonymous> (/Users/manrajsingh/Github/football-cli/node_modules/request/request.js:1048:10)
    at Request.emit (events.js:159:13)
    at IncomingMessage.<anonymous> (/Users/manrajsingh/Github/football-cli/node_modules/request/request.js:969:12)
    at IncomingMessage.emit (events.js:164:20)
    at endReadableNT (_stream_readable.js:1054:12)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)

Expected behaviour

League standings should be shown

Steps to recreate

$ football standings -l CL

People to notify

@manrajgrover

manrajgrover commented

Fixed in e1a0353