mapbox/carto

Add support for douglas-peucker simplify-algorithm

Closed this issue · 11 comments

Would it be possible to add support for the douglas-peucker simplify-algorithm?

It seems on the Mapnik side this is already implemented:

Definitely. It needs support in mapnik-reference to be usable for CartoCSS.

Just to be sure: at the moment it does not have support in Mapnik-reference?

No, that is why it is not recognized by CartoCSS as available option. Mapnik devs do not update mapnik-reference for each feature accordingly. Sometimes something is forgotten. The upcoming 1.0 release will make CartoCSS more independent from mapnik-reference. So in theory after 1.0 you could fork mapnik-reference, add the missing definition yourself and use that for CartoCSS processing if necessary.

No, in that case fixing it in mapnik-reference is clearly the way to go. Does cartocss recognize it automatically if it is added in mapbik-reference? In that case, the issue can be close sed on this side.

Unfortunately, no. After adding it to mapnik-reference that needs a new release and a new package on npm. Then I have to bump the version number here and release CartoCSS and update the package on npm. While I have the rights to do all of this I still will open a PR on mapnik-reference so that others have the chance to comment.

Clear, thanks!

Small correction. Releasing and publishing mapnik-reference is sufficient. Since it is referenced by ~ in package.json new installs of CartoCSS would pick up the change automatically.

PR pending.

Do you have an issue number?

Closing here per #487 (comment).