mapbox/variant

optional should provide == and != operators

jfirebaugh opened this issue · 7 comments

jfirebaugh commented
optional should provide == and != operators
joto commented

Our optional implementation is very incomplete compared to the upcoming standard, boost::optional or this implementation. Do we want to keep working on our own?

/cc @springmeyer

See also #63.

jfirebaugh commented

I switched mapbox-gl-native over to experimental/optional earlier this week. I support deprecating or removing our implementation.

springmeyer commented

I support deprecating or removing our implementation.

Same 👍 . For the next tagged release let's remove it.

refi64 commented

:(

springmeyer commented

I switched mapbox-gl-native over to experimental/optional earlier this week. I support deprecating or removing our implementation.

@jfirebaugh I saw you mention that you hit problems with experimental::optional? Do you see value in keeping mapbox::optional around longer or no?

jfirebaugh commented

mapbox-gl-native no longer uses mapbox::optional. We work around a couple of experimental::optional bugs on various implementations:

  • bool operator!=() const is sometimes missing (use !(a == b) instead)
  • T* operator->() const is sometimes broken (use operator* instead)
springmeyer commented

Thanks @jfirebaugh - re-closing this issue then: We'll stick with the current deprecation and future removal (at v2.x)