mapnik/node-mapnik

upgrade to latest mapnik master

Closed this issue ยท 8 comments

hi @artemp

do you plan to integrate the changes from the proj6 update or to update to the latest mapnik master?

@mathisloge can you give a bit more context here, please? node-mapnik works with latest mapnik@master, no?

Mostly. With the proj6 branch i think the proj_transform->source / dest functions were removed.
So all logs like

<< x << "," << y << " from " << proj_transform_->source().params() << " to " << proj_transform_->dest().params();
are failing.

But these are just four lines which are invalid (only in mapnik_projection.cpp)

@mathisloge I see, thanks for highlighting this. I have local proj6 branch with all the fixes but never pushed, doh.. I'll need to update to latest master and to push proj6 branch, ๐Ÿ‘

@artemp if you have some spare time, could you push your proj6 branch?
I would like to run the tests in #976 . Most of them are failing due to proj init grammar changes.

@mathisloge - I just pushed my local branch https://github.com/mapnik/node-mapnik/tree/proj6. Let me know if it works for you, cheers.

Thanks for pushing!

I'm still getting some erros with:

proj_create: init=epsg:/init=IGNF: syntax not supported in non-PROJ4 emulation mode
D:\dev\node-mapnik\test\vector-tile.composite.test.js:300
  vtile.composite([vtile2],{reencode:true});
        ^

TypeError: failed to initialize projection with: '+init=epsg:3857'
    at Test.<anonymous> (D:\dev\node-mapnik\test\vector-tile.composite.test.js:300:9)
    at Test.bound [as _cb] (D:\dev\node-mapnik\node_modules\tape\lib\test.js:88:32)
    at Test.run (D:\dev\node-mapnik\node_modules\tape\lib\test.js:105:10)
    at Test.bound [as run] (D:\dev\node-mapnik\node_modules\tape\lib\test.js:88:32)
    at Immediate.next (D:\dev\node-mapnik\node_modules\tape\lib\results.js:82:19)

Thanks for pushing!

I'm still getting some erros with:

proj_create: init=epsg:/init=IGNF: syntax not supported in non-PROJ4 emulation mode
D:\dev\node-mapnik\test\vector-tile.composite.test.js:300
  vtile.composite([vtile2],{reencode:true});
        ^

TypeError: failed to initialize projection with: '+init=epsg:3857'
    at Test.<anonymous> (D:\dev\node-mapnik\test\vector-tile.composite.test.js:300:9)
    at Test.bound [as _cb] (D:\dev\node-mapnik\node_modules\tape\lib\test.js:88:32)
    at Test.run (D:\dev\node-mapnik\node_modules\tape\lib\test.js:105:10)
    at Test.bound [as run] (D:\dev\node-mapnik\node_modules\tape\lib\test.js:88:32)
    at Immediate.next (D:\dev\node-mapnik\node_modules\tape\lib\results.js:82:19)

@mathisloge yep, proj6 branch needs updated mapnik-vector-tile https://github.com/mapbox/mapnik-vector-tile
I just pushed https://github.com/mapbox/mapnik-vector-tile/tree/proj6 <---- It might need some tweaking but should work

@artemp thanks! Now all tests are running ๐Ÿ‘