mapseed/platform

Consolidate layer grouping

Closed this issue · 7 comments

instead of making one Mapseed "layer" that includes many ESRI layers (but can't mix ESRI and non-ESRI), have one item in the legend correspond with multiple Mapseed layers.

This would have the upside of immediately giving this functionality to all kinds of layers, as opposed to just ESRI

Is this issue covered by what's introduced in #659? That PR gives us the ability to arbitrarily group layers into composite layers controlled by a single checkbox in the layers panel.

Not sure if this is a different issue though...

zmbc commented

I think they're the same. Just to clarify: can that PR allow grouping of any kinds of layers (GeoJSON, ESRI, etc)?

Right, it should work for any combination of layers. #659 doesn't actually create any new layer groups, it just wires together existing layer groups under the control of a single sidebar checkbox.

zmbc commented

You say potato, I say potato 😆
That's exactly what I had in mind for this issue. Closing.

Ah, ok. Hope I didn't step on anyone's toes here! I didn't realize at first that we had two issues open for this feature, and I was working off the other one (#557).

zmbc commented

But that issue is a subset of this one, which is why I asked my initial question: that one only concerns Shareabouts layers. I think you should just note in your PR that it closes that issue, plus allows grouping together any set of any types of layers.

Gotcha--will do.