marcinbudny/applicationinsights-owinextensions

Support for getContextPropertiesAsync

Closed this issue · 5 comments

baywet commented

Hi,
As an improvement, it'd be nice to support getContextPropertiesAsync (adding a new parameter).
This way we'd be able to implement custom tracing that reads in the body of a POST request for example.
The impact should be limited to HttpRequestTrackingMiddleware (TraceRequest, ctor, props, Invoke) as well as AppBuilderExtension (UseApplicationInsights).
Let me know if you need more information.

marcinbudny commented

Hi,
This seems reasonable. I've been thinking about changing the way getContextProperties works anyway, so that full OwinContext is passed into it, instead of request and response separately. I hope I'll have some time to look into it over the weekend.

marcinbudny commented

The work is in progress, see here. Still need to update docs and changelog though, then push to nuget.

One thing about logging the POST body: be careful. Once you read the stream, you cannot rewind it for the next middleware (like WebAPI). Recently a person told me they substitute the original stream with a MemoryStream containing copy of the data. It seemed to work, but I think it is extremely hacky. This also prevents streaming of requests.

baywet commented

Thanks for working on that on such a short delay, and thanks for the heads up. We'll only be implementing that for the QA, front end devs are building new components and sending requests to our API that are sometimes causing issues. Logging those would help us understand what's going wrong when something goes wrong.

marcinbudny commented

The version 0.5 containing the changes is now released on nuget

baywet commented

Thanks for the update and sorry for not answering earlier. I took some time off.
You're right: either the AI middleware executes before the WebAPI one and reading the stream messes up things, replacing it is hacky (made iisexpress crash on my dev box) or it executes after and then you basically cannot access the data.
I guess a proper way to do it would be to implement an attribute that executes before each method of the controller and serializes all parameters to the current operation.
Closing this one. Thanks for your help