marckhouzam/custom-prometheus-exporter

would it make sense to have binary releases on github?

jhutar opened this issue · 4 comments

jhutar commented

Hello. Would you accept a build script like:

https://github.com/oliver006/redis_exporter/blob/master/release-github-binaries.sh

I now anything about go, but I should be able to modify that script quite easily, because I think it would be handy to have pre-compiled binaries available.

marckhouzam commented

Thanks for the suggestion @jhutar ! I haven't had time recently for this project but I agree it would be nice to have a release.

In the mean time you can maybe use the docker image?
https://hub.docker.com/repository/docker/marckhouzam/custom-prometheus-exporter

jhutar commented

Hello. I do not have an immediate issue - we built the exporter and it just works. Would you be OK if I attempt to submit a PR with a script as above?

marckhouzam commented

Yes of course! But I cannot promise when I'll have time to look at it, but I'll try.

jhutar commented

Sure, no problem. Thank you!