marcoroth/stimulus-lsp

Bug: values with dash not working?

Closed this issue · 2 comments

swanson commented

image

export default class extends Controller {
  static targets = ['container']
  static values = {
    selector: String,
    frameId: String,
    url: String,
    enabled: Boolean,
    border: Boolean,
  }

Looks like frameId -> frame-id value is not getting parsed correctly?

marcoroth commented

This could very well be, let me see what's up here.

marcoroth commented

Yup, seems like this regex isn't flexible enough:

stimulus-lsp/server/src/diagnostics.ts

Line 26 in 9281685

valueAttribute = /data-(.+)-(.+)-value/