mariadb-operator/mariadb-operator

[Bug] Helm repo change breaks umbrella charts

Closed this issue · 14 comments

pschichtel commented

Documentation

Describe the bug

I deploy all my stuff with Argo CD using helm charts. All the helm charts are installed as part of an umbrella chart like this:

apiVersion: v2
name: mariadb-operator
version: '1.0'

dependencies:
- name: mariadb-operator
  repository: https://helm.mariadb.com/mariadb-operator
  version: 0.28.*

This allows me to easily add additional resource and install several charts together. The change of the helm repo that happened together with the 0.29.0/0.0.29 release causes helm dependency build on this chart to fail:

$ helm dependency build
Error: error unpacking 0.28.1 in mariadb-operator: Chart.yaml file is missing

I think this happens, because the URLs in the index.yaml end with just the version. Even though the URLs redirect to URLs that end with .tgz, helm seems to use the filename of the original URL.

julien-redel commented

Same workload, same problem.
It was working a month ago (version 0.28.1)

  • 👍1
AndrzejOlender commented

I have the same problem.

sennerholm commented

It seems to be related to not having the filename in: #676
@mmontes11 , is this on your radar?

sennerholm commented

I think it's the change in urls:
from:
- https://github.com/mariadb-operator/mariadb-operator/releases/download/helm-chart-0.28.1/mariadb-operator-0.28.1.tgz
to:
- https://helm.mariadb.com/mariadb-operator/0.28.1
that makes helm dep update to store the file as 0.28.1 instead of mariadb-operator-0.28.1.tgz that make's helm confused

  • 👍1
sennerholm commented

This is probably the last version that is working
cf2ef72
(I think it's before using hack/helm-index.sh to update the indexes, but unsure)

sennerholm commented

Ugly workaround:
cd charts; mv 0.28.1 mariadb-operator-0.28.1.tgz
And remove add it to git, remove the dependencie from Chart.yaml is getting it up. It's the same checksum of the file (and same content, but wrong name)

  • 👍1
pschichtel commented

@sennerholm you gave me the idea to use https://raw.githubusercontent.com/mariadb-operator/mariadb-operator/cf2ef72316839bf8423600fb7305c77711fbfbb4 as the repository, that works for now.

  • 👍2
mariadb-pieterhumphrey commented

this will be fixed shortly, hopefully before July 15. I will make it a point to notify you so that you can revert from the workaround
@sennerholm @pschichtel @AndrzejOlender @julien-redel

  • 👍1
mmontes11 commented

Hey there! Thanks everyone for the investigation, much appreciated.

We will look into this very soon. The idea is supporting the same URL format in the new helm registry:

From:
https://helm.mariadb.com/mariadb-operator/0.28.1

To:
https://helm.mariadb.com/mariadb-operator/releases/download/helm-chart-0.28.1/mariadb-operator-0.28.1.tgz

This way, the file path will be available on the URL, which seems to be the reason that is causing helm to misbehave. Will get back to you when the change is done.

Sorry for the inconvenience!

mmontes11 commented

This has been addressed, the index.yaml URLs preserve the previous format:
https://helm.mariadb.com/mariadb-operator/index.yaml

@sennerholm @pschichtel @AndrzejOlende @julien-redel
Could you give it a try? I did manage to install the helm chart as dependency without any issues

pschichtel commented

works, thanks!

  • 👍1
  • 🚀2
mmontes11 commented

@pschichtel great! sorry for the inconvenience folks!

  • 👍2
sennerholm commented

Works for me to, thanks for the fix

  • 👍2
julien-redel commented

Works for me, thanks !

  • 👍2