Possible bug: screener.Screener dropping first row on each page
Opened this issue · 2 comments
amichael7 commented
When running the finviz distribution from pypi, I noticed that the first row of screener results appears to be dropped. Before jumping in with a pull request, wanted to check if anyone else was having this issue.
I think I have spotted the potential issue, at line 30 of helper_functions/scraper_functions.py
the enumerate
call should start at 0 if you look at the finviz page source.
if rows != -2:
for row_number, row_data in enumerate(all_rows, 1):
data_sets.append(dict(zip(headers, row_data)))
if row_number == rows: # If we have reached the required end
break
If anyone else is having this issue, I'll put in the pull request.
RiverRo commented
My cloned copy works fine but the pypi version still omits the first rows. when will pypi be updated?