mariostoev/finviz

Sceener doesn't download all results??

Closed this issue · 17 comments

dave-lanigan commented

im using get_ticker_details() on the Screener class output and not getting all my results downloaded?

out = Screener(filters=filters, table='Performance', order='price')

print(len(out))
print(len(out.get_ticker_details()))

the above code returns two different lengths

jacobsteenhuysen commented

I have the same problem.

johnjoo1 commented

Same problem. It seems to be somewhat random on how many results it will return too.

Seems to be the same issue as #79

tombohub commented

Same thing here, it skipped the one page of results

jacobsteenhuysen commented
tombohub commented

@jacobsteenhuysen is it because finviz on pypi is not updated as in git?

  • 👍1
johnjoo1 commented

The latest version of the package fixed this for me:
pip install -U git+https://github.com/mariostoev/finviz

The package version hosted in PyPi was the one that wasn't working for me.

  • 👍2
tombohub commented

@johnjoo1 are u getting css_selector error with latest version, on python3.8?

johnjoo1 commented

@johnjoo1 are u getting css_selector error with latest version, on python3.8?

I am not.

image

jacobsteenhuysen commented
tombohub commented

@jacobsteenhuysen are you using pypi or git version?

jacobsteenhuysen commented
tombohub commented

@jacobsteenhuysen didn't try yet, I am installing it right now

tombohub commented

@jacobsteenhuysen it's working with install from github

johnjoo1 commented

If you're using it in a Jupyter notebook, remember that you'll need to restart the kernel or reload the package (not just re-import the page) after you've installed the version from github.

jacobsteenhuysen commented

ok everyone. johnjoo is right you need to pip unistall finviz and then you need to install it his way with git. it started working for my in vscode.

jordanchapian commented

ref #73 -- You can experiment with the delay settings and verify that you are getting the expected number of results.

  • 👀1
d3an commented

Changes have been merged to ensure all results are getting downloaded. The issue is that FinViz has employed rate limiting via Cloudflare, so the instantaneous data retrieval via asyncio is no longer feasible without data loss. If you pip install from the git source, the data will be retrieved, but slower (expect something like 0.5 seconds * ticker count).

$ pip install -U git+https://github.com/mariostoev/finviz

Please note that the PyPI package hasn't been updated yet.

  • 👍1