marisademeglio/eleventypub

Bug on Windows, NodeJS POSIX vs. Windows paths

Closed this issue · 1 comments

Tried it on Windows and building fails because of a paths issue. On Windows all the item paths in the resources folder are written as

[
  "D:\\path\\to\\my\\project\\resources\\css\\page.css",
  // etc.
]

I think utils.js > walk #L10 needs to be

            let itemPath = path.posix.join(dir, item);

This seems to make walk() produce the correct resources.json file:

[
  "resources/css/page.css",
  // etc.
]]

Luckily this problem is literally the first section in the NodeJS path documentation so I was able to figure it out. 😄

Thank you!

Oh thanks for looking into it, I don't use windows so this tool that I initially just wrote for myself is probably inadvertently biased. The next time I make any updates I'll have a look including at the fix you mention.