markguinn/silverstripe-shop-extendedimages

Update to SilverShop 3 / SS4

Opened this issue · 5 comments

wernerkrauss commented

Hi Mark,

I'm currently updating the module to SS4 / SilverShop3, see https://github.com/wernerkrauss/silverstripe-shop-extendedimages/tree/update-to-ss4

are you still maintaining the silvershop modules? Is the "SilverShop" namespace ok or should I use something else?

Any feedback is appreciated.

markguinn commented

Good to hear from you! I haven't had very much time to work on any of these modules lately because I'm not working in PHP or Silverstripe at all. I'll be happy to work with you to get this PR merged and tagged, or happy to add a message on my repo that suggests folks use your fork instead. Whichever you prefer. I do think the SilverShop namespace is fine to use for these extensions. I hope all is well with you!

bummzack commented

Hey Mark. Would you mind moving the module to the silvershop organization on github? https://github.com/silvershop/
Maybe a rename to silvershop-extendedimages would be in order as well.

Hope you and your family are doing well.

markguinn commented

Sure. That makes sense. Is there any value in just pulling it into SilverShop itself as part of the core image functionality? Or would you prefer to leave it out as its own module?

bummzack commented

I'd prefer to keep it as separate module. SilverShop core would ideally be more modular/slim instead of constantly growing with features.

  • 👍1
wernerkrauss commented

@markguinn any news on this? I also updated extended pricing module for a project and would be happy to PR / release an updated version. It would be cool if you can transfer the modules to the silvershop organisation, see https://help.github.com/articles/transferring-a-repository-owned-by-your-personal-account/