marklieberman/foxygestures

gestures don't work with gitweb

Opened this issue · 4 comments

Take https://xenbits.xen.org/gitweb/?p=xen.git as an example, but this appears to affect any gitweb website.

Trying to perform a gesture draws the gesture, but no action occurs as a result.

Looking at developer mode, the difference between working websites and the non-working case is

XML Parsing Error: not well-formed
Location: 
Line Number 2, Column 154:

showing up as an error on the console. (Actually, twice per gesture as far as I can see.)

I guess there's something about gitweb which is causing something to go wrong, but this is about the extent of my web debugging ability.

Can you try the fix from #359.

Interesting. That certainly makes things better - things like forwards/backwards work now. However, other actions such as Open Link In New Foreground Tab still do nothing.

I don't see any more XML errors in the debug developer console, so I'm guessing there are still other other interaction issues with xhtml pages?

Seems that the issue is that some commands are using code that checks if Element.tagName = 'A' and according to MDN
image
so I should fix my code to ignore case on tag name.

zsau commented

Confirming this is still an issue. Can I help somehow?