RNCP status error
jacobeva opened this issue · 7 comments
Describe the Bug
rncp shows an incorrect total file size. e.g. transferring a large file using it will show an inaccurate percentage and total size of file (I assume it does not account for the lossless compression in these calculations). I can tell this because it seems to exit the transfer prematurely according to the status, but the file has been successfully copied in its entirety.
To Reproduce
Copy any large file (2MB+) using rncp over a link slow enough for you to see the progress.
Expected Behavior
The file transfer status should be accurate, showing an accurate total size of the file (maybe the compressed size and then the actual size in brackets) along with an accurate percentage.
Logs & Screenshots
Please see the video below:
https://youtu.be/TD4wPWWzXmQ
System Information
- Arch Linux - Kernel 6.9.6-arch1-1
- Python 3.12
- rncp 0.7.5
Thank you! Will get it fixed :)
Fixed in 0.7.6
I've just tested this, and it actually still isn't fixed (RNS 0.8.1). I'm not sure if it's just the specific file I'm using, but you may want to double check this works properly with a 4MB file (which is what I tested it with just now). It still jumps up to completion. Also, the transfer speed is invalid at the end, it'll say something close to 1mbps (I think it is calculating this assuming the transfer speed was the time from the end of the transmission to it exiting). I can open another issue for the second problem if you want.
Transfer complete 100.0% - 4.46 MB of 4.46 MB - 624.31 Kbps
My RNode is fast but not that fast ;)
Ooh, that's some magical RNode you've got there :) Yes, please open a new issue for that, won't forget it then :)
Will do. Could you please re-open this issue as well then? Also, as a pointer, it's not only rncp which has this percentage problem, but also Sideband (when sending attachments the percentage sent is incorrect when the file is really big).
I should note that the hash map sent for the resource shows the correct transfer size on the remote (1MB).
Ok, I finally found it, no need to create a separate issue. Fix incoming.