marmelab/EventDrops

Bug with global undefined

Busteren opened this issue · 0 comments

Busteren commented

What you were expecting:

A simple example of the chart, taken from issue #244

What happened instead:

global_undefined

Steps to reproduce:

Go to the link below and download the code. Only google chrome will show stack trace in the console (FireFox doesn't).

Related code:

example code
Best to download the code as doing this fix won't work:
insert at top of js code: var global = window

Other information:

event_drop_window_undefined_fix

Here is a quick way of solving the problem (having var global = window at the top is a bit silly).
Will make a PR once in the evening

Environment

  • EventDrops version 1.3.0
  • Browser: Google Chrome Version 70.0.3538.110, FireFox 63.0.3
  • Stack trace (in case of a JS error): See image above