marp-team/marp-cli

Disable emoji in config does not work

omundy opened this issue · 3 comments

How to turn off emoji conversion altogether? I added this to my marp settings in my package.json and it doesn't work to disable emoji conversion.

		"emoji": {
			"shortcode": false,
			"unicode": false
		},

image

Also note issues with these files
image

yhatt commented

🚚 Transferred issue from Marp Core to Marp CLI. It's probably a question about Marp CLI configuration. (Recommend to ask in Marp Discussions at first: https://github.com/marp-team/marp/discussions)

To set Marp Core constructor option through Marp CLI configuration interface, you have to put settings into options field.
https://github.com/marp-team/marp-cli#example

An example of package.json:

{
  "name": "your-project",
  "private": true,
  "marp": {
    "options": {
      "emoji": {
        "shortcode": false,
        "unicode": false
      }
    }
  }
}

And networking error about twemoji.maxcdn.com has already fixed in the latest Marp Core v3.4.0. Try to export again after updating every Marp tools. (The latest Marp CLI v2.3.0 has bundled the latest Marp Core. If disabled emoji conversions, may output broken emoji characters in PDF exporting)

Refer and track to twitter/twemoji#580 to know what happening about twemoji.maxcdn.com. MaxCDN has been permanently shut down at the end of last year.

OK thank you for your help. I have finally realized the difference between the "Options" of the marp-cli and options field in the constructor. Perhaps linking "The base options for the constructor of engine" in the marp-cli "Options" table to the constructor options would be helpful.

yhatt commented

Perhaps linking "The base options for the constructor of engine" in the marp-cli "Options" table to the constructor options would be helpful.

In that context, unfortunately we cannot assert that the constructor options are for Marp Core. Marp CLI allows the engine to be replaced by another library (e.g. Marpit framework or third-party presentation libraries inherited from Marpit), and options may accept different fields from Marp Core.